Fri, 16 Jan 2009 10:58:21 +0100
Correct and improve code logic, buildconf, and packaging. In particular:
1. Use descriptive variable names <var>libs instead of just <var>.
2. Although Nokia states in all Qt builds that 'NOTE: When linking
against OpenSSL, you can override the default library names
through OPENSSL_LIBS.' and even gives an example, their own
configuration logic rejects such an attempt. Correct this by
hard coding the OpenSSL library string in the configure script.
3. Consistently use the whitespace substitution [\t ] throughout.
4. Patch the buggy INCPATH of SQL plugin Qmake project files.
5. Add the 'x11' configuration variable to the qtconfig Qmake
project using the src/gui/gui.pro file as a model. This is
needed for qtconfig although not in other tools, because
the qtconfig buildconf indirectly includes qt_x11_p.h which
is dependent on X11 headers.
6. Avoid 'ld.so: fatal: hardware capability unsupported: SSE2 AMD_3DNow'
on platforms for which the config.tests/unix/[3dnow|sse2] succeed
although unsopported at run time by testing for the x86-64
instruction set at build time and regulating hardware capabilities.
7. Correctly install the desinger plugin by explicitly building it.
8. Remove custom plugin installation logic which is unnecessary.
9. Correct removal of temporary paths from shared object files.
1 ##
2 ## mpg123.spec -- OpenPKG RPM Package Specification
3 ## Copyright (c) 2000-2008 OpenPKG Foundation e.V. <http://openpkg.net/>
4 ##
5 ## Permission to use, copy, modify, and distribute this software for
6 ## any purpose with or without fee is hereby granted, provided that
7 ## the above copyright notice and this permission notice appear in all
8 ## copies.
9 ##
10 ## THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED
11 ## WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
12 ## MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
13 ## IN NO EVENT SHALL THE AUTHORS AND COPYRIGHT HOLDERS AND THEIR
14 ## CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
15 ## SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
16 ## LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
17 ## USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
18 ## ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
19 ## OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
20 ## OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
21 ## SUCH DAMAGE.
22 ##
24 # package information
25 Name: mpg123
26 Summary: MP3 Decoder/Player
27 URL: http://www.mpg123.org/
28 Vendor: Michael Hipp
29 Packager: OpenPKG Foundation e.V.
30 Distribution: OpenPKG Community
31 Class: PLUS
32 Group: Audio
33 License: GPL
34 Version: 1.6.3
35 Release: 20090106
37 # package options
38 %option with_dev no
40 # list of sources
41 Source0: http://www.mpg123.de/download/mpg123-%{version}.tar.bz2
42 Patch0: mpg123.patch
44 # build information
45 Prefix: %{l_prefix}
46 BuildRoot: %{l_buildroot}
47 BuildPreReq: OpenPKG, openpkg >= 20040130, make
48 PreReq: OpenPKG, openpkg >= 20040130
49 AutoReq: no
50 AutoReqProv: no
52 %description
53 mpg123 is a real time MPEG Audio Player for Layer 1,2 and Layer 3.
55 %track
56 prog mpg123 = {
57 version = %{version}
58 url = http://www.mpg123.de/download.shtml
59 regex = mpg123-(__VER__)\.tar\.bz2
60 }
62 %prep
63 %setup -q
64 %patch -p0
66 %build
67 CC="%{l_cc}" \
68 CFLAGS="%{l_cflags -O}" \
69 ./configure \
70 --prefix=%{l_prefix} \
71 --mandir=%{l_prefix}/man \
72 --enable-static \
73 --disable-shared
74 %{l_make} %{l_mflags -O}
76 %install
77 rm -rf $RPM_BUILD_ROOT
78 %{l_make} %{l_mflags} install DESTDIR="$RPM_BUILD_ROOT"
79 %if "%{with_dev}" != "yes"
80 rm -rf $RPM_BUILD_ROOT%{l_prefix}/include
81 rm -rf $RPM_BUILD_ROOT%{l_prefix}/lib
82 %else
83 rm -f $RPM_BUILD_ROOT%{l_prefix}/lib/libmpg123.so*
84 rm -f $RPM_BUILD_ROOT%{l_prefix}/lib/libmpg123.la
85 rm -f $RPM_BUILD_ROOT%{l_prefix}/lib/mpg123/*.a
86 %endif
87 %{l_rpmtool} files -v -ofiles -r$RPM_BUILD_ROOT %{l_files_std}
89 %files -f files
91 %clean
92 rm -rf $RPM_BUILD_ROOT