gfx/skia/patches/archive/0002-Bug-688366-Dont-invalidate-all-radial-gradients.patch@129ffea94266 (annotated)
gfx/skia/patches/archive/0002-Bug-688366-Dont-invalidate-all-radial-gradients.patch
Sat, 03 Jan 2015 20:18:00 +0100
- author
- Michael Schloh von Bennewitz <michael@schloh.com>
- date
- Sat, 03 Jan 2015 20:18:00 +0100
- branch
- TOR_BUG_3246
- changeset 7
- 129ffea94266
- permissions
- -rw-r--r--
Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.
| michael@0 | 1 | From f310d7e8b8d9cf6870c739650324bb585b591c0c Mon Sep 17 00:00:00 2001 |
| michael@0 | 2 | From: George Wright <gwright@mozilla.com> |
| michael@0 | 3 | Date: Fri, 18 May 2012 14:11:32 -0400 |
| michael@0 | 4 | Subject: [PATCH 02/10] Bug 755869 - [5] Re-apply bug 688366 - Fix Skia |
| michael@0 | 5 | marking radial gradients with the same radius as |
| michael@0 | 6 | invalid. r=mattwoodrow |
| michael@0 | 7 | |
| michael@0 | 8 | --- |
| michael@0 | 9 | gfx/skia/src/effects/SkGradientShader.cpp | 5 ++++- |
| michael@0 | 10 | 1 files changed, 4 insertions(+), 1 deletions(-) |
| michael@0 | 11 | |
| michael@0 | 12 | diff --git a/gfx/skia/src/effects/SkGradientShader.cpp b/gfx/skia/src/effects/SkGradientShader.cpp |
| michael@0 | 13 | index 6de820b..59ba48c 100644 |
| michael@0 | 14 | --- a/gfx/skia/src/effects/SkGradientShader.cpp |
| michael@0 | 15 | +++ b/gfx/skia/src/effects/SkGradientShader.cpp |
| michael@0 | 16 | @@ -1911,7 +1911,10 @@ public: |
| michael@0 | 17 | SkPMColor* SK_RESTRICT dstC = dstCParam; |
| michael@0 | 18 | |
| michael@0 | 19 | // Zero difference between radii: fill with transparent black. |
| michael@0 | 20 | - if (fDiffRadius == 0) { |
| michael@0 | 21 | + // TODO: Is removing this actually correct? Two circles with the |
| michael@0 | 22 | + // same radius, but different centers doesn't sound like it |
| michael@0 | 23 | + // should be cleared |
| michael@0 | 24 | + if (fDiffRadius == 0 && fCenter1 == fCenter2) { |
| michael@0 | 25 | sk_bzero(dstC, count * sizeof(*dstC)); |
| michael@0 | 26 | return; |
| michael@0 | 27 | } |
| michael@0 | 28 | -- |
| michael@0 | 29 | 1.7.5.4 |
| michael@0 | 30 |
