Sat, 03 Jan 2015 20:18:00 +0100
Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.
michael@0 | 1 | /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ |
michael@0 | 2 | /* This Source Code Form is subject to the terms of the Mozilla Public |
michael@0 | 3 | * License, v. 2.0. If a copy of the MPL was not distributed with this |
michael@0 | 4 | * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ |
michael@0 | 5 | |
michael@0 | 6 | /* |
michael@0 | 7 | * |
michael@0 | 8 | * Date: 06 November 2002 |
michael@0 | 9 | * SUMMARY: arr.sort() should not output |undefined| when |arr| is empty |
michael@0 | 10 | * See http://bugzilla.mozilla.org/show_bug.cgi?id=178722 |
michael@0 | 11 | * |
michael@0 | 12 | * ECMA-262 Ed.3: 15.4.4.11 Array.prototype.sort (comparefn) |
michael@0 | 13 | * |
michael@0 | 14 | * 1. Call the [[Get]] method of this object with argument "length". |
michael@0 | 15 | * 2. Call ToUint32(Result(1)). |
michael@0 | 16 | * 3. Perform an implementation-dependent sequence of calls to the [[Get]], |
michael@0 | 17 | * [[Put]], and [[Delete]] methods of this object, etc. etc. |
michael@0 | 18 | * 4. Return this object. |
michael@0 | 19 | * |
michael@0 | 20 | * |
michael@0 | 21 | * Note that sort() is done in-place on |arr|. In other words, sort() is a |
michael@0 | 22 | * "destructive" method rather than a "functional" method. The return value |
michael@0 | 23 | * of |arr.sort()| and |arr| are the same object. |
michael@0 | 24 | * |
michael@0 | 25 | * If |arr| is an empty array, the return value of |arr.sort()| should be |
michael@0 | 26 | * an empty array, not the value |undefined| as was occurring in bug 178722. |
michael@0 | 27 | * |
michael@0 | 28 | */ |
michael@0 | 29 | //----------------------------------------------------------------------------- |
michael@0 | 30 | var UBound = 0; |
michael@0 | 31 | var BUGNUMBER = 178722; |
michael@0 | 32 | var summary = 'arr.sort() should not output |undefined| when |arr| is empty'; |
michael@0 | 33 | var status = ''; |
michael@0 | 34 | var statusitems = []; |
michael@0 | 35 | var actual = ''; |
michael@0 | 36 | var actualvalues = []; |
michael@0 | 37 | var expect= ''; |
michael@0 | 38 | var expectedvalues = []; |
michael@0 | 39 | var arr; |
michael@0 | 40 | |
michael@0 | 41 | |
michael@0 | 42 | // create empty array or pseudo-array objects in various ways |
michael@0 | 43 | var arr1 = Array(); |
michael@0 | 44 | var arr2 = new Array(); |
michael@0 | 45 | var arr3 = []; |
michael@0 | 46 | var arr4 = [1]; |
michael@0 | 47 | arr4.pop(); |
michael@0 | 48 | |
michael@0 | 49 | |
michael@0 | 50 | status = inSection(1); |
michael@0 | 51 | arr = arr1.sort(); |
michael@0 | 52 | actual = arr instanceof Array && arr.length === 0 && arr === arr1; |
michael@0 | 53 | expect = true; |
michael@0 | 54 | addThis(); |
michael@0 | 55 | |
michael@0 | 56 | status = inSection(2); |
michael@0 | 57 | arr = arr2.sort(); |
michael@0 | 58 | actual = arr instanceof Array && arr.length === 0 && arr === arr2; |
michael@0 | 59 | expect = true; |
michael@0 | 60 | addThis(); |
michael@0 | 61 | |
michael@0 | 62 | status = inSection(3); |
michael@0 | 63 | arr = arr3.sort(); |
michael@0 | 64 | actual = arr instanceof Array && arr.length === 0 && arr === arr3; |
michael@0 | 65 | expect = true; |
michael@0 | 66 | addThis(); |
michael@0 | 67 | |
michael@0 | 68 | status = inSection(4); |
michael@0 | 69 | arr = arr4.sort(); |
michael@0 | 70 | actual = arr instanceof Array && arr.length === 0 && arr === arr4; |
michael@0 | 71 | expect = true; |
michael@0 | 72 | addThis(); |
michael@0 | 73 | |
michael@0 | 74 | // now do the same thing, with non-default sorting: |
michael@0 | 75 | function g() {return 1;} |
michael@0 | 76 | |
michael@0 | 77 | status = inSection('1a'); |
michael@0 | 78 | arr = arr1.sort(g); |
michael@0 | 79 | actual = arr instanceof Array && arr.length === 0 && arr === arr1; |
michael@0 | 80 | expect = true; |
michael@0 | 81 | addThis(); |
michael@0 | 82 | |
michael@0 | 83 | status = inSection('2a'); |
michael@0 | 84 | arr = arr2.sort(g); |
michael@0 | 85 | actual = arr instanceof Array && arr.length === 0 && arr === arr2; |
michael@0 | 86 | expect = true; |
michael@0 | 87 | addThis(); |
michael@0 | 88 | |
michael@0 | 89 | status = inSection('3a'); |
michael@0 | 90 | arr = arr3.sort(g); |
michael@0 | 91 | actual = arr instanceof Array && arr.length === 0 && arr === arr3; |
michael@0 | 92 | expect = true; |
michael@0 | 93 | addThis(); |
michael@0 | 94 | |
michael@0 | 95 | status = inSection('4a'); |
michael@0 | 96 | arr = arr4.sort(g); |
michael@0 | 97 | actual = arr instanceof Array && arr.length === 0 && arr === arr4; |
michael@0 | 98 | expect = true; |
michael@0 | 99 | addThis(); |
michael@0 | 100 | |
michael@0 | 101 | |
michael@0 | 102 | |
michael@0 | 103 | //----------------------------------------------------------------------------- |
michael@0 | 104 | test(); |
michael@0 | 105 | //----------------------------------------------------------------------------- |
michael@0 | 106 | |
michael@0 | 107 | |
michael@0 | 108 | |
michael@0 | 109 | function addThis() |
michael@0 | 110 | { |
michael@0 | 111 | statusitems[UBound] = status; |
michael@0 | 112 | actualvalues[UBound] = actual; |
michael@0 | 113 | expectedvalues[UBound] = expect; |
michael@0 | 114 | UBound++; |
michael@0 | 115 | } |
michael@0 | 116 | |
michael@0 | 117 | |
michael@0 | 118 | function test() |
michael@0 | 119 | { |
michael@0 | 120 | enterFunc('test'); |
michael@0 | 121 | printBugNumber(BUGNUMBER); |
michael@0 | 122 | printStatus(summary); |
michael@0 | 123 | |
michael@0 | 124 | for (var i=0; i<UBound; i++) |
michael@0 | 125 | { |
michael@0 | 126 | reportCompare(expectedvalues[i], actualvalues[i], statusitems[i]); |
michael@0 | 127 | } |
michael@0 | 128 | |
michael@0 | 129 | exitFunc ('test'); |
michael@0 | 130 | } |