Sat, 03 Jan 2015 20:18:00 +0100
Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.
michael@0 | 1 | /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ |
michael@0 | 2 | /* This Source Code Form is subject to the terms of the Mozilla Public |
michael@0 | 3 | * License, v. 2.0. If a copy of the MPL was not distributed with this |
michael@0 | 4 | * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ |
michael@0 | 5 | |
michael@0 | 6 | /* |
michael@0 | 7 | * |
michael@0 | 8 | * Date: 16 Dec 2002 |
michael@0 | 9 | * SUMMARY: Testing |with (x) {function f() {}}| when |x.f| already exists |
michael@0 | 10 | * See http://bugzilla.mozilla.org/show_bug.cgi?id=185485 |
michael@0 | 11 | * |
michael@0 | 12 | * The idea is this: if |x| does not already have a property named |f|, |
michael@0 | 13 | * a |with| statement cannot be used to define one. See, for example, |
michael@0 | 14 | * |
michael@0 | 15 | * http://bugzilla.mozilla.org/show_bug.cgi?id=159849#c11 |
michael@0 | 16 | * http://bugzilla.mozilla.org/show_bug.cgi?id=184107 |
michael@0 | 17 | * |
michael@0 | 18 | * |
michael@0 | 19 | * However, if |x| already has a property |f|, a |with| statement can be |
michael@0 | 20 | * used to modify the value it contains: |
michael@0 | 21 | * |
michael@0 | 22 | * with (x) {f = 1;} |
michael@0 | 23 | * |
michael@0 | 24 | * This should work even if we use a |var| statement, like this: |
michael@0 | 25 | * |
michael@0 | 26 | * with (x) {var f = 1;} |
michael@0 | 27 | * |
michael@0 | 28 | * However, it should NOT work if we use a |function| statement, like this: |
michael@0 | 29 | * |
michael@0 | 30 | * with (x) {function f() {}} |
michael@0 | 31 | * |
michael@0 | 32 | * Instead, this should newly define a function f in global scope. |
michael@0 | 33 | * See http://bugzilla.mozilla.org/show_bug.cgi?id=185485 |
michael@0 | 34 | * |
michael@0 | 35 | */ |
michael@0 | 36 | //----------------------------------------------------------------------------- |
michael@0 | 37 | var UBound = 0; |
michael@0 | 38 | var BUGNUMBER = 185485; |
michael@0 | 39 | var summary = 'Testing |with (x) {function f() {}}| when |x.f| already exists'; |
michael@0 | 40 | var status = ''; |
michael@0 | 41 | var statusitems = []; |
michael@0 | 42 | var actual = ''; |
michael@0 | 43 | var actualvalues = []; |
michael@0 | 44 | var expect= ''; |
michael@0 | 45 | var expectedvalues = []; |
michael@0 | 46 | |
michael@0 | 47 | var x = { f:0, g:0 }; |
michael@0 | 48 | |
michael@0 | 49 | with (x) |
michael@0 | 50 | { |
michael@0 | 51 | f = 1; |
michael@0 | 52 | } |
michael@0 | 53 | status = inSection(1); |
michael@0 | 54 | actual = x.f; |
michael@0 | 55 | expect = 1; |
michael@0 | 56 | addThis(); |
michael@0 | 57 | |
michael@0 | 58 | with (x) |
michael@0 | 59 | { |
michael@0 | 60 | var f = 2; |
michael@0 | 61 | } |
michael@0 | 62 | status = inSection(2); |
michael@0 | 63 | actual = x.f; |
michael@0 | 64 | expect = 2; |
michael@0 | 65 | addThis(); |
michael@0 | 66 | |
michael@0 | 67 | /* |
michael@0 | 68 | * Use of a function statement under the with-block should not affect |
michael@0 | 69 | * the local property |f|, but define a function |f| in global scope - |
michael@0 | 70 | */ |
michael@0 | 71 | with (x) |
michael@0 | 72 | { |
michael@0 | 73 | function f() {} |
michael@0 | 74 | } |
michael@0 | 75 | status = inSection(3); |
michael@0 | 76 | actual = x.f; |
michael@0 | 77 | expect = 2; |
michael@0 | 78 | addThis(); |
michael@0 | 79 | |
michael@0 | 80 | status = inSection(4); |
michael@0 | 81 | actual = typeof this.f; |
michael@0 | 82 | expect = 'function'; |
michael@0 | 83 | addThis(); |
michael@0 | 84 | |
michael@0 | 85 | |
michael@0 | 86 | /* |
michael@0 | 87 | * Compare use of function expression instead of function statement. |
michael@0 | 88 | * Note it is important that |x.g| already exists. Otherwise, this |
michael@0 | 89 | * would newly define |g| in global scope - |
michael@0 | 90 | */ |
michael@0 | 91 | with (x) |
michael@0 | 92 | { |
michael@0 | 93 | var g = function() {} |
michael@0 | 94 | } |
michael@0 | 95 | status = inSection(5); |
michael@0 | 96 | actual = x.g.toString(); |
michael@0 | 97 | expect = (function () {}).toString(); |
michael@0 | 98 | addThis(); |
michael@0 | 99 | |
michael@0 | 100 | |
michael@0 | 101 | |
michael@0 | 102 | //----------------------------------------------------------------------------- |
michael@0 | 103 | test(); |
michael@0 | 104 | //----------------------------------------------------------------------------- |
michael@0 | 105 | |
michael@0 | 106 | |
michael@0 | 107 | |
michael@0 | 108 | function addThis() |
michael@0 | 109 | { |
michael@0 | 110 | statusitems[UBound] = status; |
michael@0 | 111 | actualvalues[UBound] = actual; |
michael@0 | 112 | expectedvalues[UBound] = expect; |
michael@0 | 113 | UBound++; |
michael@0 | 114 | } |
michael@0 | 115 | |
michael@0 | 116 | |
michael@0 | 117 | function test() |
michael@0 | 118 | { |
michael@0 | 119 | enterFunc('test'); |
michael@0 | 120 | printBugNumber(BUGNUMBER); |
michael@0 | 121 | printStatus(summary); |
michael@0 | 122 | |
michael@0 | 123 | for (var i=0; i<UBound; i++) |
michael@0 | 124 | { |
michael@0 | 125 | reportCompare(expectedvalues[i], actualvalues[i], statusitems[i]); |
michael@0 | 126 | } |
michael@0 | 127 | |
michael@0 | 128 | exitFunc ('test'); |
michael@0 | 129 | } |