Sat, 03 Jan 2015 20:18:00 +0100
Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.
michael@0 | 1 | /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ |
michael@0 | 2 | /* |
michael@0 | 3 | * Any copyright is dedicated to the Public Domain. |
michael@0 | 4 | * http://creativecommons.org/licenses/publicdomain/ |
michael@0 | 5 | */ |
michael@0 | 6 | |
michael@0 | 7 | function f() { |
michael@0 | 8 | return function(a) { |
michael@0 | 9 | // This eval must take place before the block is cloned, when the |
michael@0 | 10 | // call object is still not marked as a delegate. The scope chain |
michael@0 | 11 | // purge for the JSOP_DEFVAR will not change the global's shape, |
michael@0 | 12 | // and the property cache entry will remain valid. |
michael@0 | 13 | eval(a); |
michael@0 | 14 | let (c = 3) { |
michael@0 | 15 | // This eval forces the block to be cloned, so its shape gets |
michael@0 | 16 | // used as the property cache key shape. |
michael@0 | 17 | eval(''); |
michael@0 | 18 | return b; |
michael@0 | 19 | }; |
michael@0 | 20 | }; |
michael@0 | 21 | } |
michael@0 | 22 | |
michael@0 | 23 | var b = 1; |
michael@0 | 24 | var g1 = f(); |
michael@0 | 25 | var g2 = f(); |
michael@0 | 26 | |
michael@0 | 27 | /* Call the lambda once, caching a reference to the global b. */ |
michael@0 | 28 | g1(''); |
michael@0 | 29 | |
michael@0 | 30 | /* |
michael@0 | 31 | * If this call sees the above cache entry, then it will erroneously use the |
michael@0 | 32 | * global b. |
michael@0 | 33 | */ |
michael@0 | 34 | assertEq(g2('var b=2'), 2); |
michael@0 | 35 | |
michael@0 | 36 | reportCompare(true, true); |