Fri, 16 Jan 2015 18:13:44 +0100
Integrate suggestion from review to improve consistency with existing code.
michael@0 | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
michael@0 | 2 | // Use of this source code is governed by a BSD-style license that can be |
michael@0 | 3 | // found in the LICENSE file. |
michael@0 | 4 | |
michael@0 | 5 | #ifndef BASE_REFCOUNTED_H_ |
michael@0 | 6 | #define BASE_REFCOUNTED_H_ |
michael@0 | 7 | |
michael@0 | 8 | namespace base { |
michael@0 | 9 | |
michael@0 | 10 | template <typename T> |
michael@0 | 11 | class RefCounted { |
michael@0 | 12 | public: |
michael@0 | 13 | RefCounted() {} |
michael@0 | 14 | ~RefCounted() {} |
michael@0 | 15 | }; |
michael@0 | 16 | |
michael@0 | 17 | template <typename T> |
michael@0 | 18 | class RefCountedThreadSafe { |
michael@0 | 19 | public: |
michael@0 | 20 | RefCountedThreadSafe() {} |
michael@0 | 21 | ~RefCountedThreadSafe() {} |
michael@0 | 22 | }; |
michael@0 | 23 | |
michael@0 | 24 | } // namespace base |
michael@0 | 25 | |
michael@0 | 26 | // Ignore classes whose inheritance tree ends in WebKit's RefCounted base |
michael@0 | 27 | // class. Though prone to error, this pattern is very prevalent in WebKit |
michael@0 | 28 | // code, so do not issue any warnings. |
michael@0 | 29 | namespace WebKit { |
michael@0 | 30 | |
michael@0 | 31 | template <typename T> |
michael@0 | 32 | class RefCounted { |
michael@0 | 33 | public: |
michael@0 | 34 | RefCounted() {} |
michael@0 | 35 | ~RefCounted() {} |
michael@0 | 36 | }; |
michael@0 | 37 | |
michael@0 | 38 | } // namespace WebKit |
michael@0 | 39 | |
michael@0 | 40 | // Unsafe; should error. |
michael@0 | 41 | class PublicRefCountedDtorInHeader |
michael@0 | 42 | : public base::RefCounted<PublicRefCountedDtorInHeader> { |
michael@0 | 43 | public: |
michael@0 | 44 | PublicRefCountedDtorInHeader() {} |
michael@0 | 45 | ~PublicRefCountedDtorInHeader() {} |
michael@0 | 46 | |
michael@0 | 47 | private: |
michael@0 | 48 | friend class base::RefCounted<PublicRefCountedDtorInHeader>; |
michael@0 | 49 | }; |
michael@0 | 50 | |
michael@0 | 51 | // Unsafe; should error. |
michael@0 | 52 | class PublicRefCountedThreadSafeDtorInHeader |
michael@0 | 53 | : public base::RefCountedThreadSafe< |
michael@0 | 54 | PublicRefCountedThreadSafeDtorInHeader> { |
michael@0 | 55 | public: |
michael@0 | 56 | PublicRefCountedThreadSafeDtorInHeader() {} |
michael@0 | 57 | ~PublicRefCountedThreadSafeDtorInHeader() {} |
michael@0 | 58 | |
michael@0 | 59 | private: |
michael@0 | 60 | friend class base::RefCountedThreadSafe< |
michael@0 | 61 | PublicRefCountedThreadSafeDtorInHeader>; |
michael@0 | 62 | }; |
michael@0 | 63 | |
michael@0 | 64 | // Safe; should not have errors. |
michael@0 | 65 | class ProtectedRefCountedDtorInHeader |
michael@0 | 66 | : public base::RefCounted<ProtectedRefCountedDtorInHeader> { |
michael@0 | 67 | public: |
michael@0 | 68 | ProtectedRefCountedDtorInHeader() {} |
michael@0 | 69 | |
michael@0 | 70 | protected: |
michael@0 | 71 | ~ProtectedRefCountedDtorInHeader() {} |
michael@0 | 72 | |
michael@0 | 73 | private: |
michael@0 | 74 | friend class base::RefCounted<ProtectedRefCountedDtorInHeader>; |
michael@0 | 75 | }; |
michael@0 | 76 | |
michael@0 | 77 | // Safe; should not have errors. |
michael@0 | 78 | class PrivateRefCountedDtorInHeader |
michael@0 | 79 | : public base::RefCounted<PrivateRefCountedDtorInHeader> { |
michael@0 | 80 | public: |
michael@0 | 81 | PrivateRefCountedDtorInHeader() {} |
michael@0 | 82 | |
michael@0 | 83 | private: |
michael@0 | 84 | ~PrivateRefCountedDtorInHeader() {} |
michael@0 | 85 | friend class base::RefCounted<PrivateRefCountedDtorInHeader>; |
michael@0 | 86 | }; |
michael@0 | 87 | |
michael@0 | 88 | // Unsafe; A grandchild class ends up exposing their parent and grandparent's |
michael@0 | 89 | // destructors. |
michael@0 | 90 | class DerivedProtectedToPublicInHeader |
michael@0 | 91 | : public ProtectedRefCountedDtorInHeader { |
michael@0 | 92 | public: |
michael@0 | 93 | DerivedProtectedToPublicInHeader() {} |
michael@0 | 94 | ~DerivedProtectedToPublicInHeader() {} |
michael@0 | 95 | }; |
michael@0 | 96 | |
michael@0 | 97 | // Unsafe; A grandchild ends up implicitly exposing their parent and |
michael@0 | 98 | // grantparent's destructors. |
michael@0 | 99 | class ImplicitDerivedProtectedToPublicInHeader |
michael@0 | 100 | : public ProtectedRefCountedDtorInHeader { |
michael@0 | 101 | public: |
michael@0 | 102 | ImplicitDerivedProtectedToPublicInHeader() {} |
michael@0 | 103 | }; |
michael@0 | 104 | |
michael@0 | 105 | // Unsafe-but-ignored; should not have errors. |
michael@0 | 106 | class WebKitPublicDtorInHeader |
michael@0 | 107 | : public WebKit::RefCounted<WebKitPublicDtorInHeader> { |
michael@0 | 108 | public: |
michael@0 | 109 | WebKitPublicDtorInHeader() {} |
michael@0 | 110 | ~WebKitPublicDtorInHeader() {} |
michael@0 | 111 | }; |
michael@0 | 112 | |
michael@0 | 113 | // Unsafe-but-ignored; should not have errors. |
michael@0 | 114 | class WebKitDerivedPublicDtorInHeader |
michael@0 | 115 | : public WebKitPublicDtorInHeader { |
michael@0 | 116 | public: |
michael@0 | 117 | WebKitDerivedPublicDtorInHeader() {} |
michael@0 | 118 | ~WebKitDerivedPublicDtorInHeader() {} |
michael@0 | 119 | }; |
michael@0 | 120 | |
michael@0 | 121 | #endif // BASE_REFCOUNTED_H_ |