content/media/webaudio/blink/README@b8a032363ba2 (annotated)
content/media/webaudio/blink/README
Thu, 22 Jan 2015 13:21:57 +0100
- author
- Michael Schloh von Bennewitz <michael@schloh.com>
- date
- Thu, 22 Jan 2015 13:21:57 +0100
- branch
- TOR_BUG_9701
- changeset 15
- b8a032363ba2
- permissions
- -rw-r--r--
Incorporate requested changes from Mozilla in review:
https://bugzilla.mozilla.org/show_bug.cgi?id=1123480#c6
| michael@0 | 1 | This directory contains the code originally borrowed from the Blink Web Audio |
| michael@0 | 2 | implementation. We are forking the code here because in many cases the burden |
| michael@0 | 3 | of adopting Blink specific utilities is too large compared to the prospect of |
| michael@0 | 4 | importing upstream fixes by just copying newer versions of the code in the |
| michael@0 | 5 | future. |
| michael@0 | 6 | |
| michael@0 | 7 | The process of borrowing code from Blink is as follows: |
| michael@0 | 8 | |
| michael@0 | 9 | * Try to borrow utility classes only, and avoid borrowing code which depends |
| michael@0 | 10 | too much on the Blink specific utilities. |
| michael@0 | 11 | * First, import the pristine files from the Blink repository before adding |
| michael@0 | 12 | them to the build system, noting the SVN revision of Blink from which the |
| michael@0 | 13 | original files were copied in the commit message. |
| michael@0 | 14 | * In a separate commit, add the imported source files to the build system, |
| michael@0 | 15 | and apply the necessary changes to make it build successfully. |
| michael@0 | 16 | * Use the code in a separate commit. |
| michael@0 | 17 | * Never add headers as exported headers. All headers should be included |
| michael@0 | 18 | using the following convention: #include "blink/Header.h". |
| michael@0 | 19 | * Leave the imported code in the WebCore namespace, and import the needed |
| michael@0 | 20 | names into the Mozilla code via `using'. |
| michael@0 | 21 | * Cherry-pick upsteam fixes manually when needed. In case you fix a problem |
| michael@0 | 22 | that is not Mozilla specific locally, try to upstream your changes into |
| michael@0 | 23 | Blink. |
| michael@0 | 24 | * Ping ehsan for any questions. |
