The Tor Browser: build/clang-plugin/tests/TestStackClass.cpp@129ffea94266

Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.

     1 #define MOZ_STACK_CLASS __attribute__((annotate("moz_stack_class")))

     2 #include <stddef.h>

     4 struct MOZ_STACK_CLASS Stack {

     5   int i;

     6   void *operator new(size_t x) { return 0; }

     7   void *operator new(size_t blah, char *buffer) { return buffer; }

     8 };

    10 template <class T>

    11 struct MOZ_STACK_CLASS TemplateClass {

    12   T i;

    13 };

    15 void gobble(void *) { }

    17 void misuseStackClass(int len) {

    18   Stack valid;

    19   Stack alsoValid[2];

    20   static Stack notValid; // expected-error {{variable of type 'Stack' only valid on the stack}}

    21   static Stack alsoNotValid[2]; // expected-error {{variable of type 'Stack [2]' only valid on the stack}}

    23   gobble(&valid);

    24   gobble(&notValid);

    25   gobble(&alsoValid[0]);

    27   gobble(new Stack); // expected-error {{variable of type 'Stack' only valid on the stack}}

    28   gobble(new Stack[10]); // expected-error {{variable of type 'Stack' only valid on the stack}}

    29   gobble(new TemplateClass<int>); // expected-error {{variable of type 'TemplateClass<int>' only valid on the stack}}

    30   gobble(len <= 5 ? &valid : new Stack); // expected-error {{variable of type 'Stack' only valid on the stack}}

    32   char buffer[sizeof(Stack)];

    33   gobble(new (buffer) Stack);

    34 }

    36 Stack notValid; // expected-error {{variable of type 'Stack' only valid on the stack}}

    37 struct RandomClass {

    38   Stack nonstaticMember; // expected-note {{'RandomClass' is a stack class because member 'nonstaticMember' is a stack class 'Stack'}}

    39   static Stack staticMember; // expected-error {{variable of type 'Stack' only valid on the stack}}

    40 };

    41 struct MOZ_STACK_CLASS RandomStackClass {

    42   Stack nonstaticMember;

    43   static Stack staticMember; // expected-error {{variable of type 'Stack' only valid on the stack}}

    44 };

    46 struct BadInherit : Stack {}; // expected-note {{'BadInherit' is a stack class because it inherits from a stack class 'Stack'}}

    47 struct MOZ_STACK_CLASS GoodInherit : Stack {};

    49 BadInherit moreInvalid; // expected-error {{variable of type 'BadInherit' only valid on the stack}}

    50 RandomClass evenMoreInvalid; // expected-error {{variable of type 'RandomClass' only valid on the stack}}

The Tor Browser / file revision

build/clang-plugin/tests/TestStackClass.cpp@129ffea94266

build/clang-plugin/tests/TestStackClass.cpp