Sat, 03 Jan 2015 20:18:00 +0100
Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.
1 let expected = 'o!o!o!';
2 let actual = '';
4 // g is a function that needs an implicit |this| if called within a |with|
5 // statement. If we fail to provide that implicit |this|, it will append
6 // "[object global]" instead of "o!".
7 let o = {
8 g: function() { actual += this.toString(); },
9 toString: function() { return "o!"; }
10 }
12 // g's presence within the |with| is detected by simple tracking of |with|s
13 // during parsing.
14 with (o) {
15 (function() { g(); })();
16 }
18 // The eval() defeats the tracking of |with| during parsing. Instead, g's
19 // presence within the |with| is detected by looking at the scopeChain of the
20 // ParseContext.
21 with (o) {
22 eval("(function() { g(); })()");
23 }
25 // This is like the above case, but the knowledge of the |with| presence must
26 // be inherited by the inner function. This is the case that was missed in bug
27 // 786114.
28 with (o) {
29 eval("(function() { (function() { g(); })(); })()");
30 }
32 assertEq(actual, expected);