The Tor Browser: js/src/jsapi-tests/testNullRoot.cpp@129ffea94266

Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.

     1 /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 4 -*-

     2 * vim: set ts=8 sts=4 et sw=4 tw=99:

     3 */

     4 /* This Source Code Form is subject to the terms of the Mozilla Public

     5  * License, v. 2.0. If a copy of the MPL was not distributed with this

     6  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

     8 #include "jsapi-tests/tests.h"

    10 BEGIN_TEST(testNullRoot)

    11 {

    12     obj = nullptr;

    13     CHECK(JS::AddObjectRoot(cx, &obj));

    15     str = nullptr;

    16     CHECK(JS::AddStringRoot(cx, &str));

    18     script = nullptr;

    19     CHECK(JS::AddNamedScriptRoot(cx, &script, "testNullRoot's script"));

    21     // This used to crash because obj was nullptr.

    22     JS_GC(cx->runtime());

    24     JS::RemoveObjectRoot(cx, &obj);

    25     JS::RemoveStringRoot(cx, &str);

    26     JS::RemoveScriptRoot(cx, &script);

    27     return true;

    28 }

    30 JS::Heap<JSObject *> obj;

    31 JS::Heap<JSString *> str;

    32 JS::Heap<JSScript *> script;

    33 END_TEST(testNullRoot)

The Tor Browser / file revision

js/src/jsapi-tests/testNullRoot.cpp@129ffea94266

js/src/jsapi-tests/testNullRoot.cpp