The Tor Browser: js/xpconnect/src/XPCWrapper.cpp@129ffea94266

Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.

     1 /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

     2 /* vim: set ts=8 sts=2 et sw=2 tw=80: */

     3 /* This Source Code Form is subject to the terms of the Mozilla Public

     4  * License, v. 2.0. If a copy of the MPL was not distributed with this

     5  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

     7 #include "xpcprivate.h"

     8 #include "XPCWrapper.h"

     9 #include "WrapperFactory.h"

    10 #include "AccessCheck.h"

    12 using namespace xpc;

    13 using namespace mozilla;

    15 namespace XPCNativeWrapper {

    17 static inline

    18 bool

    19 ThrowException(nsresult ex, JSContext *cx)

    20 {

    21   XPCThrower::Throw(ex, cx);

    23   return false;

    24 }

    26 static bool

    27 UnwrapNW(JSContext *cx, unsigned argc, jsval *vp)

    28 {

    29   JS::CallArgs args = JS::CallArgsFromVp(argc, vp);

    30   if (args.length() != 1) {

    31     return ThrowException(NS_ERROR_XPC_NOT_ENOUGH_ARGS, cx);

    32   }

    34   JS::RootedValue v(cx, args[0]);

    35   if (!v.isObject() || !js::IsWrapper(&v.toObject())) {

    36     args.rval().set(v);

    37     return true;

    38   }

    40   if (AccessCheck::wrapperSubsumes(&v.toObject())) {

    41     bool ok = xpc::WrapperFactory::WaiveXrayAndWrap(cx, &v);

    42     NS_ENSURE_TRUE(ok, false);

    43   }

    45   args.rval().set(v);

    46   return true;

    47 }

    49 static bool

    50 XrayWrapperConstructor(JSContext *cx, unsigned argc, jsval *vp)

    51 {

    52   JS::CallArgs args = CallArgsFromVp(argc, vp);

    53   if (args.length() == 0) {

    54     return ThrowException(NS_ERROR_XPC_NOT_ENOUGH_ARGS, cx);

    55   }

    57   if (!args[0].isObject()) {

    58     args.rval().set(args[0]);

    59     return true;

    60   }

    62   args.rval().setObject(*js::UncheckedUnwrap(&args[0].toObject()));

    63   return JS_WrapValue(cx, args.rval());

    64 }

    65 // static

    66 bool

    67 AttachNewConstructorObject(JSContext *aCx, JS::HandleObject aGlobalObject)

    68 {

    69   // Pushing a JSContext calls ActivateDebugger which calls this function, so

    70   // we can't use an AutoJSContext here until JSD is gone.

    71   JSAutoCompartment ac(aCx, aGlobalObject);

    72   JSFunction *xpcnativewrapper =

    73     JS_DefineFunction(aCx, aGlobalObject, "XPCNativeWrapper",

    74                       XrayWrapperConstructor, 1,

    75                       JSPROP_READONLY | JSPROP_PERMANENT | JSFUN_STUB_GSOPS | JSFUN_CONSTRUCTOR);

    76   if (!xpcnativewrapper) {

    77     return false;

    78   }

    79   JS::RootedObject obj(aCx, JS_GetFunctionObject(xpcnativewrapper));

    80   return JS_DefineFunction(aCx, obj, "unwrap", UnwrapNW, 1,

    81                            JSPROP_READONLY | JSPROP_PERMANENT) != nullptr;

    82 }

    84 } // namespace XPCNativeWrapper

    86 namespace XPCWrapper {

    88 JSObject *

    89 UnsafeUnwrapSecurityWrapper(JSObject *obj)

    90 {

    91   if (js::IsProxy(obj)) {

    92     return js::UncheckedUnwrap(obj);

    93   }

    95   return obj;

    96 }

    98 } // namespace XPCWrapper

The Tor Browser / file revision

js/xpconnect/src/XPCWrapper.cpp@129ffea94266

js/xpconnect/src/XPCWrapper.cpp