Sat, 03 Jan 2015 20:18:00 +0100
Conditionally enable double key logic according to:
private browsing mode or privacy.thirdparty.isolate preference and
implement in GetCookieStringCommon and FindCookie where it counts...
With some reservations of how to convince FindCookie users to test
condition and pass a nullptr when disabling double key logic.
1 diff --git a/mfbt/double-conversion/utils.h b/mfbt/double-conversion/utils.h
2 --- a/mfbt/double-conversion/utils.h
3 +++ b/mfbt/double-conversion/utils.h
4 @@ -31,15 +31,15 @@
5 #include <stdlib.h>
6 #include <string.h>
8 -#include <assert.h>
9 +#include "mozilla/Assertions.h"
10 #ifndef ASSERT
11 -#define ASSERT(condition) (assert(condition))
12 +#define ASSERT(condition) MOZ_ASSERT(condition)
13 #endif
14 #ifndef UNIMPLEMENTED
15 -#define UNIMPLEMENTED() (abort())
16 +#define UNIMPLEMENTED() MOZ_CRASH()
17 #endif
18 #ifndef UNREACHABLE
19 -#define UNREACHABLE() (abort())
20 +#define UNREACHABLE() MOZ_CRASH()
21 #endif
23 // Double operations detection based on target architecture.