Thu, 22 Jan 2015 13:21:57 +0100
Incorporate requested changes from Mozilla in review:
https://bugzilla.mozilla.org/show_bug.cgi?id=1123480#c6
1 /* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
2 /* vim:set ts=2 sw=2 sts=2 et: */
3 /* This Source Code Form is subject to the terms of the Mozilla Public
4 * License, v. 2.0. If a copy of the MPL was not distributed with this
5 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
7 const bmsvc = PlacesUtils.bookmarks;
8 const histsvc = PlacesUtils.history;
10 function run_test() {
11 run_next_test();
12 }
14 add_task(function test_addBookmarksAndCheckGuids() {
15 let folder = bmsvc.createFolder(bmsvc.placesRoot, "test folder", bmsvc.DEFAULT_INDEX);
16 let b1 = bmsvc.insertBookmark(folder, uri("http://test1.com/"),
17 bmsvc.DEFAULT_INDEX, "1 title");
18 let b2 = bmsvc.insertBookmark(folder, uri("http://test2.com/"),
19 bmsvc.DEFAULT_INDEX, "2 title");
20 let b3 = bmsvc.insertBookmark(folder, uri("http://test3.com/"),
21 bmsvc.DEFAULT_INDEX, "3 title");
22 let s1 = bmsvc.insertSeparator(folder, bmsvc.DEFAULT_INDEX);
23 let f1 = bmsvc.createFolder(folder, "test folder 2", bmsvc.DEFAULT_INDEX);
25 let root = PlacesUtils.getFolderContents(folder).root;
26 do_check_eq(root.childCount, 5);
28 // check bookmark guids
29 let bookmarkGuidZero = root.getChild(0).bookmarkGuid;
30 do_check_eq(bookmarkGuidZero.length, 12);
31 // bookmarks have bookmark guids
32 do_check_eq(root.getChild(1).bookmarkGuid.length, 12);
33 do_check_eq(root.getChild(2).bookmarkGuid.length, 12);
34 // separator has bookmark guid
35 do_check_eq(root.getChild(3).bookmarkGuid.length, 12);
36 // folder has bookmark guid
37 do_check_eq(root.getChild(4).bookmarkGuid.length, 12);
38 // all bookmark guids are different.
39 do_check_neq(bookmarkGuidZero, root.getChild(1).bookmarkGuid);
40 do_check_neq(root.getChild(1).bookmarkGuid, root.getChild(2).bookmarkGuid);
41 do_check_neq(root.getChild(2).bookmarkGuid, root.getChild(3).bookmarkGuid);
42 do_check_neq(root.getChild(3).bookmarkGuid, root.getChild(4).bookmarkGuid);
44 // check page guids
45 let pageGuidZero = root.getChild(0).pageGuid;
46 do_check_eq(pageGuidZero.length, 12);
47 // bookmarks have page guids
48 do_check_eq(root.getChild(1).pageGuid.length, 12);
49 do_check_eq(root.getChild(2).pageGuid.length, 12);
50 // folder and separator don't have page guids
51 do_check_eq(root.getChild(3).pageGuid, "");
52 do_check_eq(root.getChild(4).pageGuid, "");
54 do_check_neq(pageGuidZero, root.getChild(1).pageGuid);
55 do_check_neq(root.getChild(1).pageGuid, root.getChild(2).pageGuid);
57 root.containerOpen = false;
59 remove_all_bookmarks();
60 });
62 add_task(function test_updateBookmarksAndCheckGuids() {
63 let folder = bmsvc.createFolder(bmsvc.placesRoot, "test folder", bmsvc.DEFAULT_INDEX);
64 let b1 = bmsvc.insertBookmark(folder, uri("http://test1.com/"),
65 bmsvc.DEFAULT_INDEX, "1 title");
66 let f1 = bmsvc.createFolder(folder, "test folder 2", bmsvc.DEFAULT_INDEX);
68 let root = PlacesUtils.getFolderContents(folder).root;
69 do_check_eq(root.childCount, 2);
71 // ensure the bookmark and page guids remain the same after modifing other property.
72 let bookmarkGuidZero = root.getChild(0).bookmarkGuid;
73 let pageGuidZero = root.getChild(0).pageGuid;
74 bmsvc.setItemTitle(b1, "1 title mod");
75 do_check_eq(root.getChild(0).title, "1 title mod");
76 do_check_eq(root.getChild(0).bookmarkGuid, bookmarkGuidZero);
77 do_check_eq(root.getChild(0).pageGuid, pageGuidZero);
79 let bookmarkGuidOne = root.getChild(1).bookmarkGuid;
80 let pageGuidOne = root.getChild(1).pageGuid;
81 bmsvc.setItemTitle(f1, "test foolder 234");
82 do_check_eq(root.getChild(1).title, "test foolder 234");
83 do_check_eq(root.getChild(1).bookmarkGuid, bookmarkGuidOne);
84 do_check_eq(root.getChild(1).pageGuid, pageGuidOne);
86 root.containerOpen = false;
88 remove_all_bookmarks();
89 });
91 add_task(function test_addVisitAndCheckGuid() {
92 // add a visit and test page guid and non-existing bookmark guids.
93 let now = Date.now() * 1000;
94 let sourceURI = uri("http://test4.com/");
95 yield promiseAddVisits({ uri: sourceURI });
96 do_check_eq(bmsvc.getBookmarkedURIFor(sourceURI), null);
98 let options = histsvc.getNewQueryOptions();
99 let query = histsvc.getNewQuery();
100 query.uri = sourceURI;
101 let root = histsvc.executeQuery(query, options).root;
102 root.containerOpen = true;
103 do_check_eq(root.childCount, 1);
105 do_check_valid_places_guid(root.getChild(0).pageGuid);
106 do_check_eq(root.getChild(0).bookmarkGuid, "");
107 root.containerOpen = false;
109 yield promiseClearHistory();
110 });
112 add_task(function test_addItemsWithInvalidGUIDsFails() {
113 const INVALID_GUID = "XYZ";
114 try {
115 bmsvc.createFolder(bmsvc.placesRoot, "XYZ folder",
116 bmsvc.DEFAULT_INDEX, INVALID_GUID);
117 do_throw("Adding a folder with an invalid guid should fail");
118 }
119 catch(ex) { }
121 let folder = bmsvc.createFolder(bmsvc.placesRoot, "test folder",
122 bmsvc.DEFAULT_INDEX);
123 try {
124 bmsvc.insertBookmark(folder, uri("http://test.tld"), bmsvc.DEFAULT_INDEX,
125 "title", INVALID_GUID);
126 do_throw("Adding a bookmark with an invalid guid should fail");
127 }
128 catch(ex) { }
130 try {
131 bmsvc.insertSeparator(folder, bmsvc.DEFAULT_INDEX, INVALID_GUID);
132 do_throw("Adding a separator with an invalid guid should fail");
133 }
134 catch(ex) { }
136 remove_all_bookmarks();
137 });
139 add_task(function test_addItemsWithGUIDs() {
140 const FOLDER_GUID = "FOLDER--GUID";
141 const BOOKMARK_GUID = "BM------GUID";
142 const SEPARATOR_GUID = "SEP-----GUID";
144 let folder = bmsvc.createFolder(bmsvc.placesRoot, "test folder",
145 bmsvc.DEFAULT_INDEX, FOLDER_GUID);
146 bmsvc.insertBookmark(folder, uri("http://test1.com/"), bmsvc.DEFAULT_INDEX,
147 "1 title", BOOKMARK_GUID);
148 bmsvc.insertSeparator(folder, bmsvc.DEFAULT_INDEX, SEPARATOR_GUID);
150 let root = PlacesUtils.getFolderContents(folder).root;
151 do_check_eq(root.childCount, 2);
152 do_check_eq(root.bookmarkGuid, FOLDER_GUID);
153 do_check_eq(root.getChild(0).bookmarkGuid, BOOKMARK_GUID);
154 do_check_eq(root.getChild(1).bookmarkGuid, SEPARATOR_GUID);
156 root.containerOpen = false;
157 remove_all_bookmarks();
158 });
160 add_task(function test_emptyGUIDIgnored() {
161 let folder = bmsvc.createFolder(bmsvc.placesRoot, "test folder",
162 bmsvc.DEFAULT_INDEX, "");
163 do_check_valid_places_guid(PlacesUtils.getFolderContents(folder)
164 .root.bookmarkGuid);
165 remove_all_bookmarks();
166 });
168 add_task(function test_usingSameGUIDFails() {
169 const GUID = "XYZXYZXYZXYZ";
170 bmsvc.createFolder(bmsvc.placesRoot, "test folder",
171 bmsvc.DEFAULT_INDEX, GUID);
172 try {
173 bmsvc.createFolder(bmsvc.placesRoot, "test folder 2",
174 bmsvc.DEFAULT_INDEX, GUID);
175 do_throw("Using the same guid twice should fail");
176 }
177 catch(ex) { }
179 remove_all_bookmarks();
180 });