michael@0: # HG changeset patch
michael@0: # User Georg Fritzsche <georg.fritzsche@googlemail.com>
michael@0: # Date 1366630152 -7200
michael@0: #      Mon Apr 22 13:29:12 2013 +0200
michael@0: # Node ID 11f7a9321b7d5d85eddc2db16e58e6870a7c4e06
michael@0: # Parent  e74de3db7dd27ffda8f4772f892cfb52c5c35649
michael@0: Bug 836829 - Fix missing result check in Mac exception handler. r=ted
michael@0: 
michael@0: diff --git a/src/client/mac/handler/exception_handler.cc b/src/client/mac/handler/exception_handler.cc
michael@0: --- a/src/client/mac/handler/exception_handler.cc
michael@0: +++ b/src/client/mac/handler/exception_handler.cc
michael@0: @@ -276,19 +276,23 @@ bool ExceptionHandler::WriteMinidump(boo
michael@0:  
michael@0:    use_minidump_write_mutex_ = true;
michael@0:    last_minidump_write_result_ = false;
michael@0:  
michael@0:    // Lock the mutex.  Since we just created it, this will return immediately.
michael@0:    if (pthread_mutex_lock(&minidump_write_mutex_) == 0) {
michael@0:      // Send an empty message to the handle port so that a minidump will
michael@0:      // be written
michael@0: -    SendMessageToHandlerThread(write_exception_stream ?
michael@0: -                                   kWriteDumpWithExceptionMessage :
michael@0: -                                   kWriteDumpMessage);
michael@0: +    bool result = SendMessageToHandlerThread(write_exception_stream ?
michael@0: +                                             kWriteDumpWithExceptionMessage :
michael@0: +                                             kWriteDumpMessage);
michael@0: +    if (!result) {
michael@0: +      pthread_mutex_unlock(&minidump_write_mutex_);
michael@0: +      return false;
michael@0: +    }
michael@0:  
michael@0:      // Wait for the minidump writer to complete its writing.  It will unlock
michael@0:      // the mutex when completed
michael@0:      pthread_mutex_lock(&minidump_write_mutex_);
michael@0:    }
michael@0:  
michael@0:    use_minidump_write_mutex_ = false;
michael@0:    UpdateNextID();