Mon, 16 Jan 2012 23:08:14 +0100
Inconclusively complete possibly missing fields. This change introduces
inconsistencies difficult to correct given incomplete documentation of
IPKG and OPKG packaging standards.
michael@20 | 1 | This patch is assembled according to discussions on #ofono |
michael@20 | 2 | irc.freenode.net and mailing list thread 'Problem detecting/using wwan0 |
michael@20 | 3 | modem' in June 2011, after comprehensive guidance from Denis KENZIOR. |
michael@20 | 4 | |
michael@20 | 5 | Denis had already modified plugins/udev.c in git commit |
michael@20 | 6 | 6a2847f7aba5d84b06940ee29300d4b6fd31d682 to correct detection of |
michael@20 | 7 | OEM Ericsson F3607gw modems relabeled by HP and sold as HS2330. |
michael@20 | 8 | Because some (or all?) HS2330 modems contain flawed text identifiers |
michael@20 | 9 | containing strange (probably erroneous) binary sequences in place of |
michael@20 | 10 | the ASCII space '\x20' character, the previous commit is incomplete. |
michael@20 | 11 | The following logic detects the modem properly, by comparing binary |
michael@20 | 12 | data as well as ASCII text values. |
michael@20 | 13 | |
michael@20 | 14 | Michael Schloh von Bennewitz |
michael@20 | 15 | http://michael.schloh.com/ |
michael@20 | 16 | 30 June 2011 |
michael@20 | 17 | |
michael@20 | 18 | Index: plugins/udev.c |
michael@20 | 19 | diff -Nau plugins/udev.c.orig plugins/udev.c |
michael@20 | 20 | --- plugins/udev.c.orig 2011-06-30 13:42:29.279704948 +0200 |
michael@20 | 21 | +++ plugins/udev.c 2011-06-30 13:43:48.117205221 +0200 |
michael@20 | 22 | @@ -134,6 +134,7 @@ |
michael@20 | 23 | (g_str_has_suffix(desc, "Minicard Data Modem") || |
michael@20 | 24 | g_str_has_suffix(desc, "Mini-Card Data Modem") || |
michael@20 | 25 | g_str_has_suffix(desc, "Module Data Modem") || |
michael@20 | 26 | + g_str_has_suffix(desc, "Module\xc2\xa0""Data Modem") || |
michael@20 | 27 | g_str_has_suffix(desc, "Broadband Data Modem"))) { |
michael@20 | 28 | devnode = udev_device_get_devnode(udev_device); |
michael@20 | 29 | ofono_modem_set_string(modem, DATA_DEVICE, devnode); |