Mon, 16 Jan 2012 23:08:14 +0100
Inconclusively complete possibly missing fields. This change introduces
inconsistencies difficult to correct given incomplete documentation of
IPKG and OPKG packaging standards.
1 This patch is assembled according to discussions on #ofono
2 irc.freenode.net and mailing list thread 'Problem detecting/using wwan0
3 modem' in June 2011, after comprehensive guidance from Denis KENZIOR.
5 Denis had already modified plugins/udev.c in git commit
6 6a2847f7aba5d84b06940ee29300d4b6fd31d682 to correct detection of
7 OEM Ericsson F3607gw modems relabeled by HP and sold as HS2330.
8 Because some (or all?) HS2330 modems contain flawed text identifiers
9 containing strange (probably erroneous) binary sequences in place of
10 the ASCII space '\x20' character, the previous commit is incomplete.
11 The following logic detects the modem properly, by comparing binary
12 data as well as ASCII text values.
14 Michael Schloh von Bennewitz
15 http://michael.schloh.com/
16 30 June 2011
18 Index: plugins/udev.c
19 diff -Nau plugins/udev.c.orig plugins/udev.c
20 --- plugins/udev.c.orig 2011-06-30 13:42:29.279704948 +0200
21 +++ plugins/udev.c 2011-06-30 13:43:48.117205221 +0200
22 @@ -134,6 +134,7 @@
23 (g_str_has_suffix(desc, "Minicard Data Modem") ||
24 g_str_has_suffix(desc, "Mini-Card Data Modem") ||
25 g_str_has_suffix(desc, "Module Data Modem") ||
26 + g_str_has_suffix(desc, "Module\xc2\xa0""Data Modem") ||
27 g_str_has_suffix(desc, "Broadband Data Modem"))) {
28 devnode = udev_device_get_devnode(udev_device);
29 ofono_modem_set_string(modem, DATA_DEVICE, devnode);