OpenPKG Specs: binutils/binutils.patch@4a34d7a82eab (annotated)

binutils/binutils.patch@4a34d7a82eab (annotated)

binutils/binutils.patch

Tue, 29 Mar 2011 20:04:34 +0200

author: Michael Schloh von Bennewitz <michael@schloh.com>
date: Tue, 29 Mar 2011 20:04:34 +0200
changeset 334: 4a34d7a82eab
parent 69: 84180bd0cb45
child 425: 7543b0b3134d
permissions: -rw-r--r--

Rework package yet again, correcting and introducing new buildconf logic:
Conditionally disable bootstrap stage comparison correctly, correct
english grammar, better find system as(1) and ld(1), indotruce detailed
optimization option messages, more completely guess cpu types, allow
profiled bootstrapping without a preinstalled GCC because many other
compilers have long since implemented 64-bit arithmetic, instruct make
to build sequentially (not in sparallel) when building a profiled
bootstrap as GCC online documents recommend, and generally improve
comment blocks.

The single most important correction in this changeset relates to the
GCC changed optimization policy since at least GCC 4.5, in which -march
is always passed and not always correctly guessed. In the case of this
package, allowing GCC to guess the architecture leads to wild build
errors at various subcomponents (zlib, libgcc, libiberty...) and
bootstrap stages. It seems quite platform specific, and the safest
approach to correcting this seems to be explicitly always specifying the
-march argument when bootstrapping GCC. Because the best choice 'native'
is not available when bootstrapping using a foreign (non GCC) compiler,
a guess is made according to rpmmacros l_platform in that case.

It is questionable as to whether these recent optimization changes
on the part of GCC or this package are compatible with each other,
or if either are complete or correct at all. At least applying these
corrections allows this package to build again in most cases test.

 Use the platform specific ELF branding expected under FreeBSD.
 This is similar to what the vendor ld(1) does on this platform.
 Additionally, recognize and ignore Solaris 10's "Solaris Cryptographic
 Framework" ELF header type "SUNW_signature", Solaris 10 "Symbol
 information" ELF header type "SUNW_syminfo" and Solaris 10 "DTrace
 Object Format" ELF header type. Also, fix the path to the dynamic
 linker under Solaris 10/amd64.
 Index: include/elf/common.h
 --- include/elf/common.h.orig	2010-05-18 05:31:06.000000000 +0200
 +++ include/elf/common.h	2010-12-09 16:48:56.000000000 +0100
@@ -474,6 +474,9 @@
  #define SHT_SUNW_verdef	0x6ffffffd	/* Versions defined by file */
  #define SHT_SUNW_verneed 0x6ffffffe	/* Versions needed by file */
  #define SHT_SUNW_versym	0x6fffffff	/* Symbol versions */
 +#define SHT_SUNW_syminfo 0x6ffffffc	/* Symbol information */
 +#define SHT_SUNW_signature 0x6ffffff6	/* Solaris Cryptographic Framework: Digital Signature */
 +#define SHT_SUNW_dof 0x6ffffff4	/* Solaris DTrace Object Format */
  #define SHT_GNU_verdef	SHT_SUNW_verdef
  #define SHT_GNU_verneed	SHT_SUNW_verneed
 Index: bfd/elf.c
 --- bfd/elf.c.orig	2010-10-29 14:10:24.000000000 +0200
 +++ bfd/elf.c	2010-12-09 16:48:57.000000000 +0100
@@ -1884,6 +1884,11 @@
        elf_tdata (abfd)->dynverref_hdr = *hdr;
        return _bfd_elf_make_section_from_shdr (abfd, hdr, name, shindex);
 +    case SHT_SUNW_syminfo:
 +    /* case SHT_SUNW_signature: conflicts with new SHT_GNU_HASH in Binutils 2.18 */
 +    case SHT_SUNW_dof:
 +      return TRUE;
 +
      case SHT_SHLIB:
        return TRUE;
@@ -5036,6 +5041,12 @@
    else
      i_ehdrp->e_type = ET_REL;
 +  /* OpenPKG platform branding BEGIN */
 +#if defined(OPENPKG_OS_FREEBSD)
 +  i_ehdrp->e_ident[EI_OSABI] = ELFOSABI_FREEBSD;
 +#endif
 +  /* OpenPKG platform branding END */
 +
    switch (bfd_get_arch (abfd))
      {
      case bfd_arch_unknown:
 Index: bfd/elf64-x86-64.c
 --- bfd/elf64-x86-64.c.orig	2010-10-21 14:29:02.000000000 +0200
 +++ bfd/elf64-x86-64.c	2010-12-09 16:48:57.000000000 +0100
@@ -360,7 +360,11 @@
  /* The name of the dynamic interpreter.	 This is put in the .interp
     section.  */
 +#if defined(OPENPKG_OS_SOLARIS)
 +#define ELF_DYNAMIC_INTERPRETER "/lib/amd64/ld.so.1"
 +#else
  #define ELF_DYNAMIC_INTERPRETER "/lib/ld64.so.1"
 +#endif
  /* If ELIMINATE_COPY_RELOCS is non-zero, the linker will try to avoid
     copying dynamic variables from a shared lib into an app's dynbss
 -----------------------------------------------------------------------------
 Support FreeBSD >= 4.10 by fixing platform detection.
 Index: bfd/configure
 --- bfd/configure.orig	2010-12-08 09:37:34.000000000 +0100
 +++ bfd/configure	2010-12-09 16:48:57.000000000 +0100
@@ -13876,6 +13876,10 @@
    i[3-7]86-*-bsdi)
  	COREFILE=
  	;;
 +  i[3456]86-*-freebsd4.1[0-9]*)
 +	COREFILE=''
 +	TRAD_HEADER='"hosts/i386bsd.h"'
 +	;;
    i[3-7]86-*-bsd* | i[3-7]86-*-freebsd[123] | i[3-7]86-*-freebsd[123]\.* | i[3-7]86-*-freebsd4\.[01234] | i[3-7]86-*-freebsd4\.[01234]\.* | i[3-7]86-*-freebsd*aout*)
  	COREFILE=trad-core.lo
  	TRAD_HEADER='"hosts/i386bsd.h"'
 -----------------------------------------------------------------------------
 Fight problems with --disable-nls under Solaris
 Index: gas/asintl.h
 --- gas/asintl.h.orig	2007-07-03 13:01:02.000000000 +0200
 +++ gas/asintl.h	2010-12-09 16:48:57.000000000 +0100
@@ -20,6 +20,11 @@
     Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA
 -1301, USA.  */
 +#ifndef ENABLE_NLS
 +# define _LIBINTL_H
 +# define _LIBGETTEXT_H
 +#endif
 +
  #ifdef HAVE_LOCALE_H
  # ifndef ENABLE_NLS
     /* The Solaris version of locale.h always includes libintl.h.  If we have
 Index: ld/ld.h
 --- ld/ld.h.orig	2009-11-26 14:45:25.000000000 +0100
 +++ ld/ld.h	2010-12-09 16:48:57.000000000 +0100
@@ -23,6 +23,11 @@
  #ifndef LD_H
  #define LD_H
 +#ifndef ENABLE_NLS
 +# define _LIBINTL_H
 +# define _LIBGETTEXT_H
 +#endif
 +
  #ifdef HAVE_LOCALE_H
  #endif
  #ifndef SEEK_CUR
 Index: ld/Makefile.in
 --- ld/Makefile.in.orig	2010-11-05 11:34:22.000000000 +0100
 +++ ld/Makefile.in	2010-12-09 16:48:57.000000000 +0100
@@ -360,7 +360,7 @@
  # We put the scripts in the directory $(scriptdir)/ldscripts.
  # We can't put the scripts in $(datadir) because the SEARCH_DIR
  # directives need to be different for native and cross linkers.
 -scriptdir = $(tooldir)/lib
 +scriptdir = $(libdir)
  BASEDIR = $(srcdir)/..
  BFDDIR = $(BASEDIR)/bfd
  INCDIR = $(BASEDIR)/include
 -----------------------------------------------------------------------------
 Workaround problems under Mac OS X.
 Index: libiberty/fibheap.c
 --- libiberty/fibheap.c.orig	2009-05-29 05:01:15.000000000 +0200
 +++ libiberty/fibheap.c	2010-12-09 16:48:57.000000000 +0100
@@ -34,8 +34,11 @@
  #include "libiberty.h"
  #include "fibheap.h"
 -
 +#ifdef LONG_MIN
  #define FIBHEAPKEY_MIN	LONG_MIN
 +#else
 +#define FIBHEAPKEY_MIN	(-0x7fffffffL - 1)
 +#endif
  static void fibheap_ins_root (fibheap_t, fibnode_t);
  static void fibheap_rem_root (fibheap_t, fibnode_t);
 -----------------------------------------------------------------------------
 Disable the "error" about "eh_frame_hdr" as it is actually more a
 warning (the linking is *not* aborted) and it occurs at least under
 FreeBSD-7.0/amd64 regularily without doing any obvious harm. Seems
 like the issue itself exists since a longer time, but in recent GNU
 binutils this additional message was introduced. As we cannot observe
 any problems and this message really confused, just disable it for now.
 Index: bfd/elf-eh-frame.c
 --- bfd/elf-eh-frame.c.orig	2010-04-09 16:40:15.000000000 +0200
 +++ bfd/elf-eh-frame.c	2010-12-09 16:48:57.000000000 +0100
@@ -909,9 +909,11 @@
    goto success;
   free_no_table:
 +#if 0
    (*info->callbacks->einfo)
      (_("%P: error in %B(%A); no .eh_frame_hdr table will be created.\n"),
       abfd, sec);
 +#endif
    hdr_info->table = FALSE;
    if (sec_info)
      free (sec_info);

OpenPKG Specs / annotate

binutils/binutils.patch@4a34d7a82eab (annotated)

binutils/binutils.patch