gcrypt/gcrypt.patch

Tue, 29 Mar 2011 20:04:34 +0200

author
Michael Schloh von Bennewitz <michael@schloh.com>
date
Tue, 29 Mar 2011 20:04:34 +0200
changeset 334
4a34d7a82eab
permissions
-rw-r--r--

Rework package yet again, correcting and introducing new buildconf logic:
Conditionally disable bootstrap stage comparison correctly, correct
english grammar, better find system as(1) and ld(1), indotruce detailed
optimization option messages, more completely guess cpu types, allow
profiled bootstrapping without a preinstalled GCC because many other
compilers have long since implemented 64-bit arithmetic, instruct make
to build sequentially (not in sparallel) when building a profiled
bootstrap as GCC online documents recommend, and generally improve
comment blocks.

The single most important correction in this changeset relates to the
GCC changed optimization policy since at least GCC 4.5, in which -march
is always passed and not always correctly guessed. In the case of this
package, allowing GCC to guess the architecture leads to wild build
errors at various subcomponents (zlib, libgcc, libiberty...) and
bootstrap stages. It seems quite platform specific, and the safest
approach to correcting this seems to be explicitly always specifying the
-march argument when bootstrapping GCC. Because the best choice 'native'
is not available when bootstrapping using a foreign (non GCC) compiler,
a guess is made according to rpmmacros l_platform in that case.

It is questionable as to whether these recent optimization changes
on the part of GCC or this package are compatible with each other,
or if either are complete or correct at all. At least applying these
corrections allows this package to build again in most cases test.

michael@107 1 Index: cipher/cipher.c
michael@107 2 diff -Nau cipher/cipher.c.orig cipher/cipher.c
michael@107 3 --- cipher/cipher.c.orig 2008-09-12 15:23:37.000000000 +0200
michael@107 4 +++ cipher/cipher.c 2009-02-18 19:07:30.388253084 +0100
michael@107 5 @@ -97,6 +97,10 @@
michael@107 6 { &_gcry_cipher_spec_rfc2268_40,
michael@107 7 &dummy_extra_spec, GCRY_CIPHER_RFC2268_40 },
michael@107 8 #endif
michael@107 9 +#if USE_IDEA
michael@107 10 + { &_gcry_cipher_spec_idea,
michael@107 11 + &dummy_extra_spec, GCRY_CIPHER_IDEA },
michael@107 12 +#endif
michael@107 13 #if USE_SEED
michael@107 14 { &_gcry_cipher_spec_seed,
michael@107 15 &dummy_extra_spec, GCRY_CIPHER_SEED },
michael@107 16 Index: src/cipher.h
michael@107 17 diff -Nau src/cipher.h.orig src/cipher.h
michael@107 18 --- src/cipher.h.orig 2008-09-03 12:04:42.000000000 +0200
michael@107 19 +++ src/cipher.h 2009-02-18 19:09:20.193397539 +0100
michael@107 20 @@ -105,6 +105,7 @@
michael@107 21 extern gcry_cipher_spec_t _gcry_cipher_spec_camellia128;
michael@107 22 extern gcry_cipher_spec_t _gcry_cipher_spec_camellia192;
michael@107 23 extern gcry_cipher_spec_t _gcry_cipher_spec_camellia256;
michael@107 24 +extern gcry_cipher_spec_t _gcry_cipher_spec_idea;
michael@107 25
michael@107 26 extern cipher_extra_spec_t _gcry_cipher_extraspec_tripledes;
michael@107 27 extern cipher_extra_spec_t _gcry_cipher_extraspec_aes;
michael@107 28 Index: tests/basic.c
michael@107 29 diff -Nau tests/basic.c.orig tests/basic.c
michael@107 30 --- tests/basic.c.orig 2008-09-18 16:35:57.000000000 +0200
michael@107 31 +++ tests/basic.c 2009-02-18 19:10:14.460255272 +0100
michael@107 32 @@ -1028,6 +1028,9 @@
michael@107 33 GCRY_CIPHER_CAMELLIA192,
michael@107 34 GCRY_CIPHER_CAMELLIA256,
michael@107 35 #endif
michael@107 36 +#if USE_IDEA
michael@107 37 + GCRY_CIPHER_IDEA,
michael@107 38 +#endif
michael@107 39 0
michael@107 40 };
michael@107 41 static int algos2[] = {

mercurial